Bugfix: CMake compiler_definitions inconsistent with jana_config.h #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if Xerces was present on the system, but the user set USE_XERCES=0, jana_config.h would nevertheless set JANA2_HAVE_XERCES=1 and enable Xerces-specific code. Furthermore, if Xerces is a non-system install and hence not discoverable by CMake, this causes compilation errors.
ROOT_USE_FILE _appears_ to be broken due to RootMacros.cmake being moved to the modules/ directory (Alma9 container, CVMFS /group install, Root 6.24.04). Luckily, ROOT_USE_FILE doesn't appear to be necessary (because macros such as ROOT_GENERATE_DICTIONARY are imported directly by `find_package(ROOT)`) or desirable (because the whole point of ROOT_USE_FILE is to pollute the global CMake includes/targets/CXX_FLAGS/etc). So it's an easy fix to simply remove all `include(${ROOT_USE_FILE})`.
From xerces.apache.org: > If you're looking for information regarding the old Xerces 2.x library, please be advised that Xerces 2.8.0 and all earlier releases are 100% unsupported and should no longer be used by applications.
JANA's NUMA support uses information from `lscpu` or `/proc/cpuinfo` instead of libnuma. Libnuma was insufficient because it didn't provide information about sockets or hyperthreads, and JANA2 constrains affinity/locality at any level, not just NUMA nodes.
- Converts all #ifdef's into #ifs - Removes flags from compile_definitions
This was referenced Jul 12, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved definitions for JANA2_HAVE_PODIO, etc into JVersion.h.
Removed jana_config.h completely.
Removed dead code relating to libnuma, Xerces2